Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REFACTOR: create python lib with CLI #8

Merged
merged 10 commits into from
Nov 12, 2024
Merged

REFACTOR: create python lib with CLI #8

merged 10 commits into from
Nov 12, 2024

Conversation

balbasty
Copy link
Collaborator

I started the refactoring we talked about some time ago. See draft document

I couldn't directly use satra's template as our repo already exists, but used the same project.toml (almost -- I keep the package at the repo root, rather than under src/). I haven't added all the workflows and issue tempaltes yet. Let me know which ones you think we need.

@kabilar

@calvinchai calvinchai marked this pull request as ready for review November 7, 2024 15:29
@balbasty
Copy link
Collaborator Author

balbasty commented Nov 8, 2024

Thanks @calvinchai this looks great.

@jingjingwu1225 I have modified your multi-slice jp2000 converter. See linc_convert/modalities/df/multi_slice.py. The idea is to remove hardcoded references to the data organization. Instead you'll need to run it per subject, and to pass all of the input files (although a glob in the shell should work). Could you try it quickly on one of Suzanne's subjects?

Although I guess we could merge already and test/fix df.multi_slice later. As you wish.

@jingjingwu1225
Copy link
Contributor

Hi @Yael, the reason I used 2**level in multiscales part is because it causes error if there is half voxel difference between 2 adjacent resolution levels when loading in webknossos.

@calvinchai
Copy link
Contributor

@balbasty I just talked to Jingjing and I think we might need to fix the problem she mentioned and test it. But I think it might be better to first merge this and do another PR to keep things tracked and organized (we need to update test data file in this process). Also we can test if the GitHub action is working properly through this kind of push and PR. What do you think?

@balbasty
Copy link
Collaborator Author

balbasty commented Nov 8, 2024

I agree, let's merge this!

@balbasty
Copy link
Collaborator Author

Where are we at with this? Should we merge?

@calvinchai
Copy link
Contributor

Sorry @balbasty , I was out sick yesterday and I will merge this now.

@calvinchai calvinchai merged commit 919a83f into main Nov 12, 2024
10 checks passed
jingjingwu1225 pushed a commit that referenced this pull request Nov 19, 2024
REFACTOR: create python lib with CLI
@calvinchai calvinchai deleted the refactor branch November 22, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

3 participants