-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
REFACTOR: create python lib with CLI #8
Conversation
Thanks @calvinchai this looks great. @jingjingwu1225 I have modified your multi-slice jp2000 converter. See Although I guess we could merge already and test/fix df.multi_slice later. As you wish. |
Hi @Yael, the reason I used 2**level in multiscales part is because it causes error if there is half voxel difference between 2 adjacent resolution levels when loading in webknossos. |
@balbasty I just talked to Jingjing and I think we might need to fix the problem she mentioned and test it. But I think it might be better to first merge this and do another PR to keep things tracked and organized (we need to update test data file in this process). Also we can test if the GitHub action is working properly through this kind of push and PR. What do you think? |
I agree, let's merge this! |
Where are we at with this? Should we merge? |
Sorry @balbasty , I was out sick yesterday and I will merge this now. |
REFACTOR: create python lib with CLI
I started the refactoring we talked about some time ago. See draft document
I couldn't directly use satra's template as our repo already exists, but used the same project.toml (almost -- I keep the package at the repo root, rather than under
src/
). I haven't added all the workflows and issue tempaltes yet. Let me know which ones you think we need.@kabilar